Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema manifests #13

Merged
merged 17 commits into from May 16, 2019

Conversation

Projects
None yet
2 participants
@jacoblurye
Copy link
Collaborator

commented May 15, 2019

Revamps manifest generation and validation to accommodate JSON Schema-compliant manifest template definitions.

Key changes:

  • links between manifest template fields and data models are validated using JSON Schema $ref resolution (previously, we used that "[schema].[property]" notation, which lacked validation support and can't handle schemas spread across a more complex directory structure).
  • manifest templates are more flexible and support creating templates with multiple worksheets.
  • validate_schema sub-command added to the CLI for checking that any schema in the data model is JSON Schema-compliant.
  • README documents the template schema format and workflow for adding new template schemas

@jacoblurye jacoblurye requested a review from jim-bo May 15, 2019

@jim-bo

jim-bo approved these changes May 15, 2019

Copy link
Contributor

left a comment

Seems good. I would add those integration style tests we discussed in the near future.

@jacoblurye jacoblurye force-pushed the json-schema-manifests branch from 841ddc6 to 9863b86 May 15, 2019

@jacoblurye jacoblurye force-pushed the json-schema-manifests branch from 34c5deb to 8faad1b May 16, 2019

@jacoblurye jacoblurye merged commit 59f6b01 into master May 16, 2019

@jacoblurye jacoblurye deleted the json-schema-manifests branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.