Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Olink unique gcs filepaths #157

Merged
merged 2 commits into from Sep 4, 2019

Conversation

@curlup
Copy link
Contributor

commented Sep 3, 2019

Using chip_barcode as olink_assay_run unique id.

This PR should probably be reviewed after #155 gets merged, because it's based on its branch.

@curlup curlup changed the base branch from master to fix_uuids_in_gs_urls Sep 3, 2019

@curlup curlup changed the base branch from fix_uuids_in_gs_urls to master Sep 3, 2019

@curlup curlup requested a review from jim-bo Sep 3, 2019

@curlup curlup changed the base branch from master to fix_uuids_in_gs_urls Sep 4, 2019

@jim-bo
jim-bo approved these changes Sep 4, 2019
Copy link
Contributor

left a comment

seems fine

@curlup curlup force-pushed the olink_unique_gcs_filepaths branch from 5462960 to 1ce41cf Sep 4, 2019

@curlup curlup changed the base branch from fix_uuids_in_gs_urls to master Sep 4, 2019

@curlup curlup merged commit 6b3734c into master Sep 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@curlup curlup deleted the olink_unique_gcs_filepaths branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.