Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uri rework #164

Merged
merged 6 commits into from Sep 6, 2019

Conversation

@curlup
Copy link
Contributor

commented Sep 5, 2019

GCS url now with trial id prefix and file extensions

Plus: unified merge_artifact for wes with everything else

@curlup curlup requested review from jacoblurye and jim-bo Sep 5, 2019

@jim-bo
jim-bo approved these changes Sep 6, 2019
Copy link
Contributor

left a comment

@curlup PR seems fine, I like the parameterized URIs

cidc_schemas/prism.py Show resolved Hide resolved
@jacoblurye
Copy link
Collaborator

left a comment

this looks great! just need to bump the cidc-schemas version, then good to go

@@ -223,10 +223,12 @@ def _get_recursively(search_dict, field):
LocalFileUploadEntry = namedtuple('LocalFileUploadEntry', ["local_path", "gs_key", "upload_placeholder"])

def _process_property(
row: list,
key: str,
raw_val,

This comment has been minimized.

Copy link
@jacoblurye

jacoblurye Sep 6, 2019

Collaborator

missing type hint

@curlup curlup merged commit 0180d78 into master Sep 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@curlup curlup deleted the uri_rework branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.