Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CyTOF raw fcs data model fix #277

Merged
merged 4 commits into from Jan 21, 2020
Merged

CyTOF raw fcs data model fix #277

merged 4 commits into from Jan 21, 2020

Conversation

@jacoblurye
Copy link
Collaborator

jacoblurye commented Jan 16, 2020

Update the data model and the CyTOF metadata template to account for the fact that we expect raw FCS files to be multiplexed at the batch level, rather than being at the individual sample level.

@jacoblurye jacoblurye requested review from jim-bo and jason-weirather Jan 16, 2020
@jim-bo
jim-bo approved these changes Jan 21, 2020
Copy link
Contributor

jim-bo left a comment

Changes seem reasonable to me. I hope the labs generate data according to this strategy...

@codeclimate

This comment has been minimized.

Copy link

codeclimate bot commented Jan 21, 2020

Code Climate has analyzed commit d5f4701 and detected 0 issues on this pull request.

View more on Code Climate.

@jacoblurye jacoblurye merged commit c11aede into master Jan 21, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jacoblurye jacoblurye deleted the cytof-template-fix branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.