Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registration page and unregistered user handling #160

Merged
merged 3 commits into from Nov 5, 2019

Conversation

@jacoblurye
Copy link
Contributor

jacoblurye commented Nov 5, 2019

Now, we won't attempt to fetch downloadable_files or permissions if a user is unregistered (since these requests will come back as 401s).

Also, some copy changes:
Screen Shot 2019-11-05 at 11 20 12 AM
Screen Shot 2019-11-05 at 11 20 03 AM

@jacoblurye jacoblurye requested review from curlup and jim-bo Nov 5, 2019
@curlup
curlup approved these changes Nov 5, 2019
Copy link
Contributor

curlup left a comment

didn't read all the code though

@jim-bo
jim-bo approved these changes Nov 5, 2019
Copy link

jim-bo left a comment

Text looks good.

@jacoblurye jacoblurye merged commit b16d199 into master Nov 5, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jacoblurye jacoblurye deleted the registration-page-updates branch Nov 5, 2019
jacoblurye added a commit that referenced this pull request Nov 5, 2019
* Update prod_release.yml

* Update registration page and unregistered user handling (#160)

* Update registration page and unregistered user handling

* Resolve react linter issues

* Update pending request copy

* Hot fix - prevent useEffect from spinning (#161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.