From e7641e73268ccf9d7c8d9244a73baedf608bdde0 Mon Sep 17 00:00:00 2001 From: Albert Sawczyn Date: Tue, 8 Mar 2022 16:58:16 +0100 Subject: [PATCH] fix: fix artifacts naming --- embeddings/pipeline/hps_pipeline.py | 4 +++- embeddings/pipeline/lightning_classification.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/embeddings/pipeline/hps_pipeline.py b/embeddings/pipeline/hps_pipeline.py index 2cd32a7ee..dd5d0e880 100644 --- a/embeddings/pipeline/hps_pipeline.py +++ b/embeddings/pipeline/hps_pipeline.py @@ -123,11 +123,13 @@ def run(self, run_name: Optional[str] = None, **kwargs: Any) -> Tuple[pd.DataFra return study.trials_dataframe(), metadata def objective(self, trial: optuna.trial.Trial) -> float: + run_name = f"study_{trial.study.study_name}_trial_{trial.number}".replace("/", "__") + parameters = self.config_space.sample_parameters(trial=trial) parsed_params = self.config_space.parse_parameters(parameters) kwargs = self._get_evaluation_metadata(parsed_params) pipeline = self._init_evaluation_pipeline(**kwargs) - results = pipeline.run(run_name=f"study_{trial.study.study_name}_trial_{trial.number}") + results = pipeline.run(run_name=run_name) metric = results[self.metric_name][self.metric_key] assert isinstance(metric, float) return metric diff --git a/embeddings/pipeline/lightning_classification.py b/embeddings/pipeline/lightning_classification.py index 16ea13fcc..4bc51180e 100644 --- a/embeddings/pipeline/lightning_classification.py +++ b/embeddings/pipeline/lightning_classification.py @@ -105,7 +105,7 @@ def run(self, run_name: Optional[str] = None) -> Dict[str, Any]: if self.logging_kwargs["use_wandb"]: wandb.log_artifact( str(self.output_path.joinpath(self.evaluation_filename)), - name=self.evaluation_filename, + name=f"{run_name}_{self.evaluation_filename}", type="output", ) wandb.finish()