Restore non-arch dependant path for the pkgconfig file #1012
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 17 17
Lines 4546 4556 +10
Branches 0 971 +971
==========================================
+ Hits 4546 4556 +10 ☔ View full report in Codecov by Sentry. |
|
@phlptp, looks like you moved it, was there a reason? |
|
I was going to by the pkg-config docs Which has the default location in the lib directory. I don't use pkg-config much so if we are sure the new location is cross platform and the tests pass, other than making a comment in the cmake file I have no issue changing it. |
Using GNUInstallDirs as the wrapper to install files, we have:
Which on my experience has worked well to define the paths of the pkgconfig files for all kind of projects. Let me know if you see any use case that is failing due to this change. |
|
On some projects the datadir is used to store model files and other "data" necessary for program operation or examples. Mixing library information into that seems a bit counterintuitive to me, but if that is what you regularly use, and pkgconfig works normally with that I would suggest adding a comment in the cmake file, and go forward with it. |
| @@ -4,4 +4,4 @@ else() | |||
| configure_file("cmake/CLI11.pc.in" "CLI11.pc" @ONLY) | |||
| endif() | |||
|
|
|||
| install(FILES "${PROJECT_BINARY_DIR}/CLI11.pc" DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig") | |||
| install(FILES "${PROJECT_BINARY_DIR}/CLI11.pc" DESTINATION "${CMAKE_INSTALL_DATADIR}/pkgconfig") | |||
There was a problem hiding this comment.
This change is wrong at least when using cli11 in compiled mode. The binary artifact (libCLI11) is very much arch dependant.
Noticed while updating the vcpkg package.
Originally setup at #635 but reverted in #916 without any specific reason that I can find.