Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new and shift triggers #125

Merged
merged 1 commit into from Dec 20, 2014

Conversation

Projects
None yet
2 participants
@AlchemyUnited
Copy link
Contributor

commented Dec 19, 2014

I'm working on getting the select2 field type working in a repeat group. in order to do so, i needed these triggers.

note: some of the background / solution w/ regards to select2 can be found here:

mustardBees/cmb-field-select2#10

once these are merged, i'll do a PR for the select2 fixes as well.

p.s. I read somewhere that WP was going to (for lack of a better word) embrace select2 in a future release. perhaps it would make sense for CMB2 to have select2 as native sooner rather than later? just a thought.

@jtsternberg jtsternberg merged commit 134ac37 into CMB2:master Dec 20, 2014

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.