Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh CMB2/feature/nested-fields-trunk with latest #467

Open
wants to merge 28 commits into
base: feature/nested-fields-trunk
from

Conversation

@sc0ttkclark
Copy link
Contributor

sc0ttkclark commented Sep 25, 2015

So @wpscholar can do PRs against CMB2/nested-fields-trunk directly.

pglewis added 28 commits Sep 6, 2015
…field group (used for `id` and `name` attributes in the markup)
… now protected with access provided through `__get()`; the former `_id` and `_name` are now made available via the `get_html_id_attribute()` and `get_html_name_attribute()` dynamic methods in the field group object.
… now protected with access provided through `__get()`; the former `_id` and `_name` are now made available via the `get_html_id_attribute()` and `get_html_name_attribute()` dynamic methods in the field group object.
@jtsternberg

This comment has been minimized.

Copy link
Member

jtsternberg commented Sep 30, 2015

This is a lot to review and as such, will take some time. Just giving a heads up.

@sc0ttkclark

This comment has been minimized.

Copy link
Contributor Author

sc0ttkclark commented Sep 30, 2015

OH you mean it's not going to be a quick 5 minute glance? :)

@sc0ttkclark

This comment has been minimized.

Copy link
Contributor Author

sc0ttkclark commented Nov 12, 2015

I think we can merge this into the CMB2 branch, and then have @wpscholar add his PR for the backbone tweaks on that same branch, then we can work out the merge into master or trunk branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.