Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field comments #675

Merged
merged 5 commits into from Jun 29, 2016

Conversation

@jamesgol
Copy link
Contributor

commented Jun 28, 2016

No description provided.

jamesgol added 5 commits Jun 28, 2016
Update phpdoc for save_field
Noticed in testing that the result can be bool, int, or occasionally array
Update phpdoc for save_field
Noticed in testing that the result can be bool, int, or occasionally array
Remove other extra commit from branch
Argh, too many 8 year old kids running around distracting me
@jtsternberg

This comment has been minimized.

Copy link
Member

commented Jun 29, 2016

Hmm, why did you add array|int| to the return comment? $updated will only ever be a boolean, unless I'm missing something.

@jamesgol

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2016

When I was debugging it returns the value of update_metadata which can be false, the meta ID of the object, and in some weird case it was actually an array. I'll have to trace back when I have a chance to see why it would be an array

@jtsternberg

This comment has been minimized.

Copy link
Member

commented Jun 29, 2016

@jamesgol nah, no need, I didn't dig that deep in to update_metadata to verify, but sounds like you're on it. Thanks!

@jamesgol

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2016

The 'test_get_oembed_delete_with_expired_ttl' test gets a return of an array. Looks like the remove_data() function is returning an array, that doc probably needs updated too

@jtsternberg jtsternberg merged commit 2fe7e4e into CMB2:trunk Jun 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jtsternberg

This comment has been minimized.

Copy link
Member

commented Jun 29, 2016

I'll take any doc updates you want to send. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.