New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Eviction #2

Open
dabercro opened this Issue Nov 8, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@dabercro
Collaborator

dabercro commented Nov 8, 2018

Right now, the console loops through all workflows in its database while updating errors seen. Since workflows with errors add up quickly, this now takes forever.

It would be good to have some way of looping through a subset of workflows. This can either be looking at workflows that are newer than some age, or only looking at workflows that appear with status "manual" in http://cms-unified.web.cern.ch/cms-unified/public/statuses.json (what the old console does).

@vlimant may be able to suggest a table or query that can be directly made to get the workflows that make the statuses.json page.

@dabercro

This comment has been minimized.

Collaborator

dabercro commented Nov 8, 2018

@vargasa I would assign this to you, but it looks like you need to be a collaborator first. (Invite was just sent.) Let me know if you have any other questions on this issue.

@vargasa vargasa self-assigned this Nov 8, 2018

@vlimant

This comment has been minimized.

vlimant commented Nov 15, 2018

the json file on the web is not used, the console reads directly in oracle

https://github.com/CMSCompOps/wtc-console/blob/master/src/unified/models.py

@vlimant

This comment has been minimized.

vlimant commented Nov 15, 2018

there seems to be something here

# TODO old data cleanup here

as a hook for cleaning

@dabercro

This comment has been minimized.

Collaborator

dabercro commented Nov 15, 2018

Ah, I guess I meant, the statuses.json can still be used as a way to determine what the loop should be. How are workflows evicted from that JSON file?

@vlimant

This comment has been minimized.

vlimant commented Nov 15, 2018

do not tie to the json file. evicting anything that is not in "manual" anymore is an ok way.

@vlimant

This comment has been minimized.

vlimant commented Nov 15, 2018

although, we might want to keep much more, if we are going to use the new console as the new unified report (which was one of the goal here)

@dabercro

This comment has been minimized.

Collaborator

dabercro commented Nov 15, 2018

Okay @vargasa I think that means that you'll need to connect to the Oracle database to fill the tasks table. Also, we'll need to add a filter (status like "%manual%" for a first pass) that isn't there right now.

@vlimant

This comment has been minimized.

vlimant commented Nov 15, 2018

.filter(status__icontains='manual') \

maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment