New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-728: Add ability to request payload encryption in smoke test client #130

Merged
merged 3 commits into from Jan 14, 2019

Conversation

Projects
None yet
3 participants
@rnagle
Copy link
Collaborator

rnagle commented Jan 10, 2019

Fixes BCDA-728

This adds the --encrypt flag/option to bcda_client.go, enabling us to test file encryption routine as part of our smoke tests (if we choose to, eventually). In all events, this affords us an easy way to manually validate file encryption.

Proposed changes:

To request encryption during smoke tests, add the --encrypt flag to go run bcda_client.go ... invocation.

go run bcda_client.go \
  --host=$HOST \
  --timeout=600 \
  --endpoint=Patient \
  --token=$TOKEN \
  --proto=https \
  --encrypt

@rnagle rnagle requested a review from msnook Jan 10, 2019

@msnook

This comment has been minimized.

Copy link
Collaborator

msnook commented Jan 10, 2019

Looks like the branch is out of date. Can you update it before I review?

@rnagle rnagle force-pushed the rnagle/smoke-test-encryption branch from 58bc7ee to 8fdf6e5 Jan 10, 2019

@msnook
Copy link
Collaborator

msnook left a comment

LGTM

@rnagle rnagle dismissed stale reviews from knollfear and msnook via f728279 Jan 14, 2019

@rnagle rnagle force-pushed the rnagle/smoke-test-encryption branch from d6d2494 to f728279 Jan 14, 2019

@knollfear
Copy link
Contributor

knollfear left a comment

LGTM

@rnagle rnagle merged commit 0aa97ec into master Jan 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rnagle rnagle deleted the rnagle/smoke-test-encryption branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment