New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knollfear/bcda-740B revisions with Jenn regarding the static site. #164

Merged
merged 6 commits into from Feb 6, 2019

Conversation

Projects
None yet
3 participants
@knollfear
Copy link
Contributor

knollfear commented Feb 6, 2019

Fixes BCDA-740

Jenn had some feedback on the design that I am patching up.

Proposed changes:

changed levels of some content
changed up menu
changed font
bolded CTA header
changed gradient size for big monitors
made links open externally if they are not on the cms domain
other things??

Change Details

markdown changes
CSS changes
header html changes

Security Implications

no PII is affected

Acceptance Validation

Jenn reviewed the static site. It should still look good locally

Feedback Requested

Any

@knollfear knollfear requested review from embh and rnagle Feb 6, 2019

Show resolved Hide resolved bcda/_site/404.html Outdated
@rnagle
Copy link
Collaborator

rnagle left a comment

This is looking good. 👍

Please update the meta info in _config.yml with real values (the description, in particular, is used in several <meta /> tags when the site is built). We should exercise our SEO smarts and make sure whatever we use here plays well with search engines that may index the site.

Show resolved Hide resolved bcda-site-static/index.md
@rnagle

This comment has been minimized.

Copy link
Collaborator

rnagle commented Feb 6, 2019

One other thing I noticed when testing locally, some of the font files requested in CSS result in 404 errors:

image

Looking in bcda/_site/assets/ directory, they are definitely missing. Is that something we can/should fix?

knollfear added some commits Feb 6, 2019

@knollfear

This comment has been minimized.

Copy link
Contributor Author

knollfear commented Feb 6, 2019

One other thing I noticed when testing locally, some of the font files requested in CSS result in 404 errors:

image

Looking in bcda/_site/assets/ directory, they are definitely missing. Is that something we can/should fix?

I commented them out in the source CSS file. It should stop happening.

@rnagle

rnagle approved these changes Feb 6, 2019

Copy link
Collaborator

rnagle left a comment

LGTM. 👍

@knollfear knollfear merged commit 71ab718 into master Feb 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@knollfear knollfear deleted the knollfear/bcda-740B branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment