Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-672: More flexible tag/release process #179

Merged
merged 10 commits into from Feb 19, 2019

Conversation

Projects
None yet
2 participants
@msnook
Copy link
Collaborator

msnook commented Feb 15, 2019

Fixes BCDA-672

The current tag/release process, which is driven by a Jenkins job, does not tag or create release notes for the bcda-ops repo. In addition, it does not provide the flexibility to supply a tag name.

Proposed changes:

The Jenkins job, and underlying scripts used by the Jenkins job, will be updated to:

  1. Tag the app and ops repos at the same time.
  2. Create release notes for the app and ops repos at the same time.
  3. Update the underlying tag/release scripts to be more flexible to support a repo path that is passed in as an argument.

Change Details

Changes were made to both the bcda-app repo and the bcda-ops repo.
Changes for the bcda-ops repo can be found in this PR: CMSgov/bcda-ops#133

  1. Updated README (ops changes)
  2. Updated the Jenkins job to tag and release the bcda-ops repo at the same time as the bcda-app repo (ops changes)
  3. Updated the tag/release scripts to be more flexible to support a repo path that is passed in as an argument (app changes)
  4. Updated the Jenkins Dockerfile to include installation of gpg (ops changes)

Security Implications

None.

Acceptance Validation

I created and deployed several tagged releases (some using the automated naming convention, and some using the manual naming option). Some screenshots for a select few of the test releases (for both app and ops repos) can be viewed below. (Note that these test releases have since been removed from the repository.)
In addition, screenshots for the deployments to dev are also included.

screen shot 2019-02-15 at 11 55 10 am

screen shot 2019-02-15 at 12 12 06 pm

screen shot 2019-02-15 at 11 20 56 am

screen shot 2019-02-15 at 11 21 52 am

Feedback Requested

Please review.

msnook added some commits Feb 15, 2019

@msnook msnook requested review from rnagle and knollfear Feb 15, 2019

@rnagle
Copy link
Collaborator

rnagle left a comment

This looks great. Excellent work. Will add a few comments/questions to the related ops PR, but am comfortable approving this as-is. 👍

@msnook

This comment has been minimized.

Copy link
Collaborator Author

msnook commented Feb 19, 2019

Based on the ops change, I have removed the release target from the Makefile. I have also removed Dockerfile.release.
Tested thoroughly through Jenkins, and all tests have passed.
Ready for another review.

@rnagle

rnagle approved these changes Feb 19, 2019

Copy link
Collaborator

rnagle left a comment

LGTM. 👍

@msnook msnook merged commit 74a69f3 into master Feb 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@msnook msnook deleted the msnook/bcda-672 branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.