-
Notifications
You must be signed in to change notification settings - Fork 4
Resolver for Asset.url must have a "type" property. #12
Conversation
Add default type for Asset.url
Update KenticoKontentSource.js
Noticed description was used in the documentation but wasn't pulled through with a default description. This would stop the query used in the documentation from working. This fixes it but unsure if there was a reason for it being omitted. Please reject/comment if so. |
Any chance we can get this PR into the build? I am running with this fix and it works. btw thank you for this fix and npm! |
Hi @markcoole, First off - thank you for submitting this PR, and sorry it has taken me so long to get around to reviewing it. I can reproduce the issue where Gridsome throws an error I cannot reproduce an issue related to the second commit that adds Of course, if you have had an issue that has been fixed by adding Otherwise I am happy to accept the PR, but can I ask two things, please:
Thanks again, |
Remove 'description' field from getAssetSchemaResolvers() as the resolver definition is separate to the Asset type definition.
Hey @CMeeg, I've removed description getAssetSchemaResolvers() method and changed the branch over to develop. Noticed this has pulled in a few release commits. If you'd rather I can create a pull request from my develop rather than my master? |
Thanks for doing that @markcoole. No worries, I have squashed the commits so that has ironed things out nicely. I'll work on pushing a new release soon with your fix included. |
This fix has been included in 0.4.1. Thanks again for your contribution @markcoole. |
@CMeeg and @markcoole Just tried the 0.4.1 release and works great! Thanks so much!!! |
This is just adding a default "type" of string so that it doesn't break.
For testing purpose I have tried running "gridsome develop" with an asset included, excluded and without the asset type used in the Kentico. This is is just a work around to get the solution to build without the use of images on the site. I don't know if this has any implications elsewhere but my project is running fine now. Please do check ok and feedback if issues.