Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Program::GetIR to handle programs with multiple devices #392

Merged
merged 2 commits into from Jun 7, 2020
Merged

Fix Program::GetIR to handle programs with multiple devices #392

merged 2 commits into from Jun 7, 2020

Conversation

9prady9
Copy link
Contributor

@9prady9 9prady9 commented Jun 5, 2020

Fixes #391

Local tests on a system with multiple NVIDIA GPUs passed. Regular run on a single GPU system also looks good.

@CNugteren
Copy link
Owner

Thanks a lot, good to hear it works. Code looks good as well. Could you add two minor things to the PR and then I'll merge it:

  1. Add a line in the file CHANGELOG with something like - Fixed a bug in the caching when using a context with multiple devices
  2. Add a comment in the function you modified at the loop over bin-sizes indicating that we make the assumption here that there is only one valid program (which is valid for the current use of GetIR).

@9prady9
Copy link
Contributor Author

9prady9 commented Jun 5, 2020

Will do, I shall send in the changes by tomorrow EOD.

@CNugteren CNugteren merged commit 41f344d into CNugteren:master Jun 7, 2020
@9prady9 9prady9 deleted the fix_Program_getIR branch July 7, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow issue in Program::getIR with a queue created from context with multiple devices
2 participants