Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI, based on actions-rs recommendations #1

Merged
merged 1 commit into from Feb 2, 2020

Conversation

@luizirber
Copy link
Contributor

luizirber commented Feb 1, 2020

This PR is similar to one I made for gaffy last week: ekg/gaffy#1, my comment there:

The actions-rs project maintains actions and example workflows for running CI jobs for Rust in GitHub Actions. This is similar to their quickstart, with extra jobs for macOS and Windows.
I use a similar workflow in sourmash, with some extra checks ("coverage" and "minimum supported Rust version" can also be useful to set up here).

I also like the clippy job, because it is a very good pair programmer (I always learn a lot of new idioms and better ways to write my code).

The fmt job can be removed, but cargo fmt is also pretty useful to run (and have a consistent formatting style for the code).

While there are no tests yet, this workflow is also set up to run them when they exist.

@luizirber luizirber mentioned this pull request Feb 1, 2020
@rob-p rob-p merged commit 4c3aa28 into COMBINE-lab:master Feb 2, 2020
@luizirber luizirber deleted the luizirber:ci branch Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.