API Easier construction of BranchCollector #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 12, 2019 11:17
BranchCollector.collect no longer needs the number of perturbations passed. By assuming that all the branches on the reader will have the same number of perturbations (including nominal), placeholder perturbations will be used instead. The user can always set the perturbation vector after collecting
Ease of use method for constructing a branch collector directly from a file. With this, the reading of the file and collecting of branching data is contained in one method. Method also supports passing perturbations or unknown perturbations (e.g. None) Add a simple test that uses just the file path to read and collect the branched data.
If something other than a BranchingReader is passed when creating a BranchCollector, assume a coefficient file and read using a BranchingReader. This simplifies the creating and the fromFile method
drewejohnson
added
the
API - Compatible
DanKotlyar
approved these changes
Feb 13, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes that help create BranchCollector objects:
collectis not necessary. If we assume that all the branches have the same number of perturbations, then we can determine this information from the BranchReader. This allows the user to simply doBranchCollector.collect()and then set the perturbations later.BranchCollector.fromFilecan be used to create a collector and process all group constants, e.g.passing the perturbations to this method is also allowed
3. Pass a file path to the instantiation method. This will create a BranchingReader and read the file with that.