Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minimal and core configs from access-om2 repo #183

Open
nichannah opened this issue Jan 9, 2020 · 2 comments
Open

Remove minimal and core configs from access-om2 repo #183

nichannah opened this issue Jan 9, 2020 · 2 comments
Assignees

Comments

@nichannah
Copy link
Contributor

@nichannah nichannah commented Jan 9, 2020

On a fresh pull the access-om2 control directory contains the following experiments:

01deg_jra55_iaf
01deg_jra55_ryf
025deg_core2_nyf
025deg_jra55_iaf
025deg_jra55_ryf
1deg_core_nyf
1deg_jra55_iaf
1deg_jra55_ryf
minimal_01deg_jra55_iaf
minimal_01deg_jra55_ryf

We should bring this down to the minimum that will be tested and maintained as code or standard configs change. AFAIK he minimal_ configs are not used much and could be dropped.

@nichannah nichannah self-assigned this Jan 9, 2020
@aekiss

This comment has been minimized.

Copy link
Contributor

@aekiss aekiss commented Jan 10, 2020

I agree.

This was discussed in https://arccss.slack.com/archives/C6PP0GU9Y/p1574995599016100
The consensus seemed to be that we should cease maintenance of these

025deg_core2_nyf
1deg_core_nyf

and maintain these only when needed for dev work

minimal_01deg_jra55_iaf
minimal_01deg_jra55_ryf

and that none of these four should be in the access-om2 control directory, i.e. leave them all on github, but don't include these four as submodules in access-om2.

@aekiss

This comment has been minimized.

Copy link
Contributor

@aekiss aekiss commented Jan 15, 2020

A quick bit of googling shows there are many recipes for "the one right way" to remove submodules. What's worse, most of them have a surprising number of steps, including making changes in .git, which seems dodgy.

Does anyone have a recommended method?

@aekiss aekiss changed the title Remove minimal configs from access-om2 repo Remove minimal and core configs from access-om2 repo Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.