Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema.org markup fixed, unittest added #1633

Merged
merged 1 commit into from Jan 12, 2016

Conversation

mephinet
Copy link
Contributor

This patch fixes the schema.org microdata embedded in the metacpan POD page. The result can be seen in Google's Structured Data Testing Tool - see the screenshot:
example
Other pages that use the same includes are not affected at all.

I added a unittest to assure that things stay like that :-)
Fixes #1629.

@oalders
Copy link
Member

oalders commented Jan 12, 2016

👍 Thanks!

oalders added a commit that referenced this pull request Jan 12, 2016
schema.org markup fixed, unittest added
@oalders oalders merged commit b8f0d74 into metacpan:master Jan 12, 2016
@haarg
Copy link
Member

haarg commented Jan 14, 2016

This has messed up the layout on the sidebar.
screen shot 2016-01-14 at 12 47 37 pm

@mephinet
Copy link
Contributor Author

one extra space in front of the (  ?

-------- Ursprüngliche Nachricht --------
Von: Graham Knop notifications@github.com
Datum:14.01.2016 18:48 (GMT+01:00)
An: CPAN-API/metacpan-web metacpan-web@noreply.github.com
Cc: Philipp Gortan mephinet@gmx.net
Betreff: Re: [metacpan-web] schema.org markup fixed, unittest added (#1633)

This has messed up the layout on the sidebar.


Reply to this email directly or view it on GitHub.

@mephinet
Copy link
Contributor Author

@haarg: correct - if the review is not an integer, but has a .5, it occupies to much horizontal space (even though hidden) that a line break occurs. I'll fix that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema.org microdata broken
3 participants