Add Network component #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takuyakanbr
commented
Mar 10, 2018
•
takuyakanbr
commented
- Add GoogleBooksApi class that allows searching books and obtaining book details using Google Books API
- Add request and result events for searching books and obtaining book details using Google Books API
- Add new dependency async-http-client
* Add class GoogleBooksApi that allows searching books and obtaining getting book details using Google Books API * Add request and result events for searching books using Google Books API * Add new dependency async-http-client
* Add methods and deserializers to convert JSON response from Google Books API into a Book / BookShelf
* Add wrapper classes for AsyncHttpClient and Response from async-http-client to allow easier unit testing
qiu-siqi
reviewed
Mar 10, 2018
|
|
||
| /** | ||
| * Returns the URL encoded form the string {@code s}. | ||
| * @throws NullPointerException if {@code s} is null. |
| return URLEncoder.encode(s, "UTF-8"); | ||
| } catch (UnsupportedEncodingException e) { | ||
| return ""; | ||
| } |
There was a problem hiding this comment.
Should mention in method description that it returns empty string if invalid
| * @return a CompletableFuture that resolves to a ReadOnlyBookShelf. | ||
| */ | ||
| public CompletableFuture<ReadOnlyBookShelf> searchBooks(String parameters) { | ||
| String requestUrl = URL_SEARCH_BOOKS.replace("%s", StringUtil.urlEncode(parameters)); |
| * @return a CompletableFuture that resolves to a Book. | ||
| */ | ||
| public CompletableFuture<Book> getBookDetails(String bookId) { | ||
| String requestUrl = URL_BOOK_DETAILS.replace("%s", StringUtil.urlEncode(bookId)); |
| return httpClient | ||
| .makeGetRequest(url) | ||
| .thenApply(response -> { | ||
| assert response.getContentType().startsWith(CONTENT_TYPE_JSON); |
* Remove 'Google' from the name of API request and result events * Use String.format to create request urls from url constants
qiu-siqi
reviewed
Mar 10, 2018
| @@ -59,7 +59,10 @@ public GoogleBooksApi(HttpClient httpClient) { | |||
| return httpClient | |||
| .makeGetRequest(url) | |||
| .thenApply(response -> { | |||
| assert response.getContentType().startsWith(CONTENT_TYPE_JSON); | |||
| if (response.getContentType().startsWith(CONTENT_TYPE_JSON)) { | |||
qiu-siqi
approved these changes
Mar 10, 2018
qiu-siqi
added
status.accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.