Skip to content
This repository was archived by the owner on Feb 12, 2021. It is now read-only.

WIP Overhaul of ELIXIR Permissions API specification #15

Closed
teemukataja wants to merge 27 commits into from
Closed

WIP Overhaul of ELIXIR Permissions API specification #15

teemukataja wants to merge 27 commits into from

Conversation

@teemukataja
Copy link
Contributor

@teemukataja teemukataja commented Nov 7, 2018 •
edited
Loading

WIP do not merge

Current ELIXIR Permissions API specification (1.2)
Suggestion for new specification (1.3)

This pull request overhauls the current ELIXIR Permissions API from specification 1.2 to the suggested specification 1.3.

Changes in 1.3:

  • Completely new JSON schema;
  • More descriptive fields in payload body;
  • HTTP status codes according to standards;
  • API key validation from REMS database instead of container environment.

Steps to take before merging:

  • Review specification (Juha, Martin, Alexander)
  • Review code
  • Improve unit test coverage, Fixes Increase test coverage #19
  • Inform ELIXIR AAI about the change (do not merge until ELIXIR AAI has updated their service to consume the new format)

New issues

@teemukataja teemukataja added the enhancement New feature or request label Nov 7, 2018
@teemukataja teemukataja self-assigned this Nov 7, 2018
blankdots
blankdots suggested changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@teemukataja teemukataja mentioned this pull request Nov 20, 2018
Closed
@teemukataja teemukataja mentioned this pull request Dec 11, 2018
Closed
@teemukataja
Copy link
Contributor Author

teemukataja commented Jun 7, 2019

Superceded by new API spec

@teemukataja teemukataja closed this Jun 7, 2019
@teemukataja teemukataja deleted the overhaul/newspec branch June 10, 2019 04:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@juhtornr juhtornr Awaiting requested review from juhtornr

1 more reviewer

@blankdots blankdots blankdots requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@teemukataja teemukataja

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Increase test coverage Substitute ELIXIR ID for eppn in REMS POST/PATCH endpoint DELETE endpoint

3 participants

@teemukataja @blankdots