New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event localization test to actually catch missing keys #917

Closed
Macroz opened this Issue Feb 11, 2019 · 1 comment

Comments

2 participants
@Macroz
Copy link
Collaborator

Macroz commented Feb 11, 2019

https://github.com/CSCfi/rems/blob/master/test/clj/rems/test/db_localization.clj#L36

The test does not actually catch misspelled localization keys. Also the use of fake tempura does not test much and we should rather test against each language file.

@Macroz Macroz created this issue from a note in Rems task board (Ideas) Feb 11, 2019

@Macroz

This comment has been minimized.

Copy link
Collaborator Author

Macroz commented Feb 11, 2019

See #916

@opqdonut opqdonut moved this from Ideas to In Progress in Rems task board Feb 11, 2019

@opqdonut opqdonut self-assigned this Feb 11, 2019

@Macroz Macroz closed this in #919 Feb 12, 2019

@hukka hukka moved this from In Progress to Done in Rems task board Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment