Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept licenses command #1070

Merged
merged 24 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@Macroz
Copy link
Collaborator

commented Apr 5, 2019

Applicant and member is treated the same and can use the new accept-licenses command for accepting all the terms of use. The previous checkbox solution is removed.

Member attributes are shown if there are any (e.g. Malice in test users)

See #653

@Macroz Macroz changed the title Accept licenses command WIP: Accept licenses command Apr 5, 2019

Macroz added some commits Apr 8, 2019

feat: clean up leftovers
- remove old way of storing accepted licenses
feat: only fetch application instead of reload
- reload original application after accepting licenses
- don't overwrite input field values
Show resolved Hide resolved src/cljs/rems/application.cljs Outdated
Show resolved Hide resolved src/cljc/rems/text.cljc Outdated

Macroz added some commits Apr 8, 2019

feat: more cleanup and test fixes
- accepted under license

@Macroz Macroz changed the title WIP: Accept licenses command Accept licenses command Apr 8, 2019

@opqdonut
Copy link
Collaborator

left a comment

some comments/suggestions but all in all a very clean implementation

Show resolved Hide resolved resources/translations/fi.edn Outdated
Show resolved Hide resolved src/clj/rems/application/events.clj
Show resolved Hide resolved src/clj/rems/db/test_data.clj
Show resolved Hide resolved src/cljs/rems/application.cljs
Show resolved Hide resolved src/cljs/rems/application.cljs Outdated
Show resolved Hide resolved test/clj/rems/workflow/test_dynamic.clj

Macroz added some commits Apr 9, 2019

@Macroz Macroz merged commit 40d2d83 into master Apr 9, 2019

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@Macroz Macroz deleted the accept-licenses-command branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.