Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #1124

Merged
merged 4 commits into from Apr 15, 2019

Conversation

Projects
None yet
2 participants
@Macroz
Copy link
Collaborator

commented Apr 15, 2019

Small fixes to issues found after testing the latest version or based on discussions.

Macroz added some commits Apr 15, 2019

feat: accepting licenses is not modification
As per discussion, let's not consider license acceptance a change of
the application but only activity.
refactor: remove x-rems-user-id
- for the UI x-rems-user-id is recorded in the session so it does not
  need to be sent
- remove some unnecessary parameters to simplify code

@Macroz Macroz changed the title Small fixes 2019 04 15 Small fixes Apr 15, 2019

@opqdonut opqdonut merged commit efb7533 into master Apr 15, 2019

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@opqdonut opqdonut deleted the small-fixes-2019-04-15 branch Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.