Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitted column #1244

Merged
merged 8 commits into from May 15, 2019

Conversation

Projects
None yet
2 participants
@Macroz
Copy link
Collaborator

commented May 13, 2019

Closes #1229

  • Shows submitted for applicant, reporter and handler. For the applicant it's shown in addition to created.
  • Submitted is tracked from the very first submit.
  • Refactors application-list/component to remove extra layers.
  • Fix the heading to be h1. That's the future with A11Y

Macroz added some commits May 13, 2019

refactor: simplify code
- inline constants
- remove unnecessary magic fns
- each place of use knows and owns its columns
fix: remove applicant column
- unnecessary column for applicant
feat: page heading
Use h1 for heading and show h2 only for reporter
@@ -120,7 +120,7 @@
[:h4 (text :t.catalogue/continue-existing-application)]
[application-list/component
;; TODO: use application-list/visible-columns like on other pages?

This comment has been minimized.

Copy link
@opqdonut

opqdonut May 14, 2019

Collaborator

unnecessary TODO?

This comment has been minimized.

Copy link
@Macroz

Macroz May 14, 2019

Author Collaborator

Yes I think I just made it redundant

@opqdonut

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2019

sorry, conflicts with my change

opqdonut and others added some commits May 14, 2019

@Macroz Macroz merged commit c503811 into master May 15, 2019

7 checks passed

WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@Macroz Macroz deleted the submitted-column branch May 15, 2019

@Macroz Macroz referenced this pull request May 15, 2019

Merged

Add page titles #1247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.