Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/entitlements api 1249 #1250

Merged
merged 8 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@Macroz
Copy link
Collaborator

commented May 15, 2019

Closes #1249

@@ -65,6 +65,7 @@
{:resource s/Str
:application-id s/Num
:start s/Str
:end s/Str

This comment has been minimized.

Copy link
@opqdonut

opqdonut May 15, 2019

Collaborator

the tests don't test :end at all. what value do we get when the db doesn't have an end date?

This comment has been minimized.

Copy link
@Macroz

Macroz May 15, 2019

Author Collaborator

I think I'll add some date checking here because this is a very valuable API anyway. Even though it may duplicate something of the db level tests.

This comment has been minimized.

Copy link
@Macroz

Macroz May 15, 2019

Author Collaborator

I'll add improved acceptance tests in another PR because we want this fix to be deployed for tomorrow.

@Macroz Macroz merged commit 6f99507 into master May 15, 2019

7 checks passed

WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@Macroz Macroz deleted the fix/entitlements-api-1249 branch May 15, 2019

@Macroz Macroz referenced this pull request May 15, 2019

Closed

vTHL4: Entitlement API enhancements #1001

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.