Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTML element roles #1306

Merged
merged 5 commits into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@luontola
Copy link
Collaborator

commented May 29, 2019

Closes #1212

luontola added some commits May 29, 2019

remove <nav> from footer
"It's not necessary for all links to be contained in a <nav> element.
<nav> is intended only for major block of navigation links; typically
the <footer> element often has a list of links that don't need to be in
a <nav> element."
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/nav

@luontola luontola referenced this pull request May 29, 2019

Closed

A11Y: Use HTML element roles #1212

4 of 4 tasks complete
Show resolved Hide resolved src/clj/rems/css/styles.clj Outdated
@Macroz

Macroz approved these changes Jun 4, 2019

@Macroz Macroz merged commit 592ba16 into master Jun 4, 2019

7 checks passed

WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@Macroz Macroz deleted the html-element-roles branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.