Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro texts and small UX improvements #1338

Merged
merged 32 commits into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@Macroz
Copy link
Collaborator

commented Jun 12, 2019

Implements a first pass of #1228. Likely the texts can be improved a lot and should perhaps be customized per instance. REMS demo site should perhaps introduce to REMS concept more than e.g. LBR site.

Also improve the application-state component and heading to show the application id and description.

Front page is tuned to match better the included intro text.

Catalogue page texts and sections are a little uneasy on the eyes at the moment. Perhaps they can still be improved.

Perhaps this is enough until more real user feedback.

@Macroz Macroz requested a review from okahilak Jun 12, 2019

Show resolved Hide resolved resources/translations/en.edn Outdated
Show resolved Hide resolved resources/translations/fi.edn Outdated
Show resolved Hide resolved resources/translations/en.edn Outdated
Show resolved Hide resolved resources/translations/en.edn Outdated
Show resolved Hide resolved resources/translations/fi.edn Outdated
Show resolved Hide resolved resources/translations/fi.edn Outdated
Show resolved Hide resolved resources/translations/en.edn Outdated
Show resolved Hide resolved resources/translations/en.edn Outdated
Show resolved Hide resolved resources/translations/fi.edn Outdated
Show resolved Hide resolved resources/translations/en.edn Outdated
@okahilak
Copy link
Collaborator

left a comment

Overall, many nice improvements to the UI. I'd like to make another pass after some of the comments are addressed.

(I'm not completely sure yet how I feel about the general premise of increasing verbosity here and there in the UI. I think at least some of the headings are self-explanatory enough that there is a risk that adding text could make it slightly harder at least for an experienced user to navigate. But I think that's a topic for another discussion, and something where the actual user tests might actually be useful, definitely not something that this patch needs to set in stone.)

@Macroz Macroz merged commit 969b22d into master Jun 14, 2019

7 checks passed

WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@Macroz Macroz deleted the intro branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.