Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation and disabled #1582

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@Macroz
Copy link
Collaborator

commented Sep 5, 2019

Closes #1571 now that the floating actions is merged. See the issue for a screenshot.

Macroz added 2 commits Sep 4, 2019
feat: improve error message
There are field errors and other kinds of errors such as the disabled
items warning. The disabled items case is handled by the new
wording. Field errors talk about an error in the field so it's
unnecessary to repeat the word field here.
feat: style disabled items warning as danger
There are multiple problems currently with disabled items and change
resources. However this warning used to be really an error
i.e. `danger` because that's how it is for the regular user. Handlers
should be allowed to act despite this.

@opqdonut opqdonut requested a review from okahilak Sep 5, 2019

@okahilak
Copy link
Collaborator

left a comment

Clever solution, approved.

@okahilak okahilak merged commit 05329db into master Sep 9, 2019

7 checks passed

WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@luontola luontola deleted the validation-and-disabled branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.