Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move add-licenses button to licenses box #1674

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@opqdonut
Copy link
Collaborator

commented Oct 1, 2019

fixes #1668

Definition of Done / Review checklist

Reviewability

  • link to issue
@opqdonut

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

I think this is minor enough not to warrant a changelog entry

@@ -362,6 +362,10 @@
:accepted (contains? accepted-licenses (:license/id license))
:readonly readonly?)
show-accepted-licenses?]))
(when (contains? permissions :application.command/add-licenses)

This comment has been minimized.

Copy link
@Macroz

Macroz Oct 1, 2019

Collaborator

This assumes that the add-licences and accept-licenses functionality are never enabled for the same user, which is fine but it's a silent assumption.

This comment has been minimized.

Copy link
@opqdonut

opqdonut Oct 1, 2019

Author Collaborator

Good point. This is what it looks like when both are enabled:
add-and-accept

@Macroz
Macroz approved these changes Oct 1, 2019
@Macroz Macroz merged commit 05d85cb into master Oct 1, 2019
7 checks passed
7 checks passed
WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details
@Macroz Macroz deleted the add-licenses-button-1668 branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.