Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rems.application: tune layout of licenses #1675

Merged
merged 5 commits into from Oct 1, 2019

Conversation

@opqdonut
Copy link
Collaborator

commented Oct 1, 2019

in particular, fix expanded long text licenses

fixes #1671

Definition of Done / Review checklist

Reviewability

  • link to issue
  • consider adding screenshots for ease of review
in particular, fix expanded long text licenses

fixes #1671
@opqdonut

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

Screenshot after change:

license-layout

@Macroz

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

I think it would look better if the ok mark is next to the name of the license i.e. not centered vertically.

incorporate checkbox in license components instead of using flex rows
@opqdonut

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

now it looks like this:
license-layout-2

@opqdonut

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

better screenshot, with text expanded:
license-layout-3

@Macroz
Macroz approved these changes Oct 1, 2019
Copy link
Collaborator

left a comment

Good enough

@opqdonut

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

now looks like this:
license-layout-4

@opqdonut opqdonut merged commit 2912e13 into master Oct 1, 2019
7 checks passed
7 checks passed
WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details
@opqdonut opqdonut deleted the long-licenses-1671 branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.