Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make changing language more robust #1677

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@Macroz
Copy link
Collaborator

commented Oct 1, 2019

Possibly helps with flaky change-language test to wait for the clicked component to be visible.

Copy link
Collaborator

left a comment

code is fine, please rerun circle a couple of times to check for flakiness

@Macroz Macroz merged commit c50d615 into master Oct 1, 2019
7 checks passed
7 checks passed
WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details
@Macroz Macroz deleted the wait-in-test branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.