Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow creating items with mixed organizations in admin ui #2038

Merged
merged 4 commits into from Mar 6, 2020

Conversation

@opqdonut
Copy link
Collaborator

opqdonut commented Mar 6, 2020

for #1893

Definition of Done / Review checklist

Reviewability

  • link to issue

Documentation

  • update changelog if necessary
@opqdonut opqdonut mentioned this pull request Mar 6, 2020
22 of 22 tasks complete
@opqdonut opqdonut force-pushed the organization-ui-revert-1893 branch from 38a171e to a58aabe Mar 6, 2020
@opqdonut opqdonut force-pushed the organization-ui-revert-1893 branch from a58aabe to d2a7cdc Mar 6, 2020
@Macroz
Macroz approved these changes Mar 6, 2020
Copy link
Collaborator

Macroz left a comment

I think one thing that we should add, especially since we have the space (i.e. wide dropdowns), is to show the organization in the dropdowns while creating a catalogue item. So show e.g. "perf: Performance tests", "thl: THL form".

The search for the catalogue items in the autocomplete would ideally also allow using organization name as the search term, not it only uses the title. This could be added as an idea, but it'd be nice to show the organizations at least for each item.

@opqdonut opqdonut merged commit 875bb5f into master Mar 6, 2020
6 checks passed
6 checks passed
WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details
@opqdonut opqdonut deleted the organization-ui-revert-1893 branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.