Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for adding attachments to comments #2047

Merged
merged 18 commits into from Mar 19, 2020
Merged

API for adding attachments to comments #2047

merged 18 commits into from Mar 19, 2020

Conversation

@opqdonut
Copy link
Collaborator

opqdonut commented Mar 9, 2020

for #1928

Definition of Done / Review checklist

Reviewability

  • link to issue

API

  • API is documented and shows up in Swagger UI
  • API is backwards compatible or completely new
  • Events are backwards compatible

Documentation

  • update changelog if necessary

Testing

  • complex logic is unit tested
  • valuable features are integration / browser / acceptance tested automatically

Follow-up

  • no critical TODOs left to implement
src/clj/rems/application/events.clj Outdated Show resolved Hide resolved
src/clj/rems/api/services/command.clj Outdated Show resolved Hide resolved
@opqdonut opqdonut force-pushed the attachments-1928 branch from c122e22 to 611d445 Mar 10, 2020
@Macroz
Macroz approved these changes Mar 18, 2020
Copy link
Collaborator

Macroz left a comment

Just some small things.

src/clj/rems/api/services/attachment.clj Outdated Show resolved Hide resolved
src/clj/rems/application/commands.clj Outdated Show resolved Hide resolved
src/clj/rems/application/commands.clj Outdated Show resolved Hide resolved
src/clj/rems/application/events.clj Outdated Show resolved Hide resolved
test/clj/rems/api/test_applications.clj Outdated Show resolved Hide resolved
test/clj/rems/application/test_model.clj Show resolved Hide resolved
@Macroz
Macroz approved these changes Mar 19, 2020
@opqdonut opqdonut merged commit 67080d7 into master Mar 19, 2020
6 checks passed
6 checks passed
WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details
@opqdonut opqdonut deleted the attachments-1928 branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.