Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify & fix documentation of :extra-pages config option #2072

Merged
merged 2 commits into from Mar 24, 2020

Conversation

@opqdonut
Copy link
Collaborator

opqdonut commented Mar 23, 2020

fixes #2070

:en {:title "About"
:file "about-en.md"}}}]
;;
;; Example: defines an external page and a markdown page:

This comment has been minimized.

Copy link
@Macroz

Macroz Mar 24, 2020

Collaborator

How about something like this:
;; Example: define an external static HTML page that will be linked to
And the other with
;; Example: a page generated from local Markdown files

This comment has been minimized.

Copy link
@opqdonut

opqdonut Mar 24, 2020

Author Collaborator

I wanted to demonstrate how you can have multiple definitions in an array. I'll try to make it clearer....

This comment has been minimized.

Copy link
@Macroz

Macroz Mar 24, 2020

Collaborator

Yeah just thought that it would be clearer if you split them and described what they actually are

This comment has been minimized.

Copy link
@opqdonut

opqdonut Mar 24, 2020

Author Collaborator

how about now?

@Macroz
Macroz approved these changes Mar 24, 2020
@opqdonut opqdonut merged commit 7f3baa4 into master Mar 24, 2020
6 checks passed
6 checks passed
WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details
@opqdonut opqdonut deleted the doc-defaults branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.