Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy attachments when copying application #2084

Merged
merged 4 commits into from Mar 26, 2020
Merged

copy attachments when copying application #2084

merged 4 commits into from Mar 26, 2020

Conversation

@opqdonut
Copy link
Collaborator

opqdonut commented Mar 25, 2020

fixes #2056

Definition of Done / Review checklist

Reviewability

  • link to issue

Documentation

  • update changelog if necessary

Testing

  • complex logic is unit tested
  • valuable features are integration / browser / acceptance tested automatically

Follow-up

  • no critical TODOs left to implement
@Macroz
Macroz approved these changes Mar 25, 2020
Copy link
Collaborator

Macroz left a comment

I think there is some improvements possible in copied-field-values. Otherwise looks fine.

src/clj/rems/application/commands.clj Outdated Show resolved Hide resolved
@opqdonut opqdonut merged commit 441df7a into master Mar 26, 2020
6 checks passed
6 checks passed
WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details
@opqdonut opqdonut deleted the copy-attachments-2056 branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.