refactor: factor out user-selection widget for actions #2426
Conversation
Also drop the now-unused :t.actions/request-selection translation. The request-review dialog should've been using the plural form all along anyway.
opqdonut
force-pushed
the
refactor-actions-2
branch
from
cf26161
to
826d5c2
Compare
| :item-key :userid | ||
| :item-label :display | ||
| :item-selected? #(contains? (set selected-deciders) %) | ||
| :multi? true |
There was a problem hiding this comment.
See here, decider selection has had multi? true. The event & command also support multiple users.
There was a problem hiding this comment.
Well it could potentially be wrong. We don't have it as configurable and I guess that's ok for now, but the assumption we had in an earlier discussion couple weeks ago (when doing the wording change) was that there would only ever be one decider.
There was a problem hiding this comment.
Which wording change? Looking at the history, the label has been :t.actions/request-selection and multi? has been true at least since 2019-08-01, commit a6c15aa.
There was a problem hiding this comment.
Right! What do you propose? I find that the UI is clear enough even with multiselection, and it doesn't really do any harm to support multiple deciders.
There was a problem hiding this comment.
Well I would just like to confirm from @jaakkocsc that it's so far ok to have multiple deciders. The changes look fine otherwise.
There was a problem hiding this comment.
I'd say the decision on having only one decider or multiple deciders is organisational, by the "organisation-owner", not a technical limitation set by REMS.
There was a problem hiding this comment.
It simplifies REMS to have all the invites/requests to be available for multiple people.
related to #2040
Definition of Done / Review checklist
Reviewability