New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor members and implement viewing #912

merged 11 commits into from Feb 10, 2019


None yet
2 participants
Copy link

Macroz commented Feb 8, 2019

See #609 and #870.

  • Removes add member support for old applications
  • Splits add member events to add member (REMS user, handler action only) and invite member (not rems user, handler and applicant depending on state)
  • Implements a view of the additional members of an application as well as invited members.

Macroz added some commits Feb 5, 2019

feat: add malice to fake users as applicant2
NB: demo data already had two applicants
refactor: split to components
- applicants-info, applicant-info and members-info
feat: slurp only when not string
Shows correct error in some test failure scenarios
feat: split add-member into add and invite
- change schemas to have specific fields for each
- use s/Any schema for dynamic events because :member value schema conflicts
- format applicant, members and invited members
- applicant can only invite members
- handler can invite and add members
feat: localize member events
Also fix tests to check both old and dynamic event types

foxlynx approved these changes Feb 8, 2019

Show resolved Hide resolved resources/translations/en.edn Outdated
Show resolved Hide resolved resources/translations/fi.edn
Show resolved Hide resolved src/clj/rems/db/applications.clj

@Macroz Macroz merged commit 88c0406 into master Feb 10, 2019

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
ci/circleci: cloverage Your tests passed on CircleCI!
ci/circleci: doo Your tests passed on CircleCI!
ci/circleci: ok Your tests passed on CircleCI!
ci/circleci: war Your tests passed on CircleCI!
ci/circleci: without-db Your tests passed on CircleCI!

@Macroz Macroz deleted the view-members branch Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment