Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show latest modified in UI #985

Merged
merged 5 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@hukka
Copy link
Collaborator

hukka commented Mar 5, 2019

Fix #843.

Looks like
image

Show resolved Hide resolved src/cljs/rems/application.cljs Outdated
Show resolved Hide resolved resources/translations/en.edn Outdated
@Macroz

This comment has been minimized.

Copy link
Collaborator

Macroz commented Mar 5, 2019

Alternative placement for the last modified could be just showing the last event and its time. For hidden events just show the time and say "Processed" or something. This would avoid the disconnect between the last modified time and the last event being different.

@luontola

This comment has been minimized.

Copy link
Collaborator

luontola commented Mar 5, 2019

"Last modified" can mean two things: when the application's content was last modified (i.e. draft saved or submitted) or when there last was some meta activity such as commenting or adding a member. Using a different term for those two things would help to avoid the ambiguity, for example last modified vs. last activity.

@Macroz Macroz self-assigned this Mar 11, 2019

@Macroz

Macroz approved these changes Mar 11, 2019

@Macroz Macroz merged commit 04b19a9 into master Mar 11, 2019

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@Macroz Macroz deleted the 843-latest-modified branch Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.