Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table #986

Merged
merged 9 commits into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@Macroz
Copy link
Collaborator

Macroz commented Mar 5, 2019

Closes #886 by implementing last three points i.e.

  • refactor to simplify component function
  • (initial) sort by multiple columns
  • table is not responsive to small sizes (header does not adjust)
@opqdonut
Copy link
Collaborator

opqdonut left a comment

code looks ok, didn't try the usability

@Macroz Macroz merged commit 41c9e43 into master Mar 5, 2019

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cloverage Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@Macroz Macroz deleted the refactor-table branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.