Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support db users in fake login #987

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@Macroz
Copy link
Collaborator

Macroz commented Mar 6, 2019

Previously we matched user against fake user data but since we read the users from the database we can match against them in the fake login and allow logging in with any of them.

feat: support db users in fake login
Previously we matched user against fake user data but since we read
the users from the database we can match against them in the fake
login and allow logging in with any of them.

@Macroz Macroz requested a review from foxlynx Mar 6, 2019

@foxlynx

foxlynx approved these changes Mar 6, 2019

@Macroz Macroz merged commit 993c533 into master Mar 6, 2019

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cloverage Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@Macroz Macroz deleted the improved-fake-login branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.