Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

email sending #995

Merged
merged 24 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@opqdonut
Copy link
Collaborator

opqdonut commented Mar 12, 2019

for #652

Show resolved Hide resolved src/clj/rems/poller/email.clj Outdated
Show resolved Hide resolved src/clj/rems/poller/email.clj Outdated
Show resolved Hide resolved src/clj/rems/poller/email.clj Outdated
Show resolved Hide resolved src/clj/rems/poller/email.clj

opqdonut added some commits Mar 12, 2019

rems.poller.email: resolving user email addresses
postal manages to send emails now
rems.poller.email: review comments
- remove redundant when-not
- use :last-processed-event-id in poller state
- event ids start from 1
- add comment about thread safety

@opqdonut opqdonut force-pushed the email-poller-652 branch from c0c21ae to 27d88c0 Mar 13, 2019

@opqdonut opqdonut changed the title WIP: email sending email sending Mar 13, 2019

@luontola
Copy link
Collaborator

luontola left a comment

Looks good. Just some small tweaks.

Show resolved Hide resolved src/clj/rems/poller/email.clj Outdated
Show resolved Hide resolved src/clj/rems/poller/email.clj Outdated
Show resolved Hide resolved src/clj/rems/poller/email.clj Outdated
Show resolved Hide resolved src/clj/rems/poller/email.clj Outdated

opqdonut added some commits Mar 13, 2019

@opqdonut opqdonut merged commit 42d9d6c into master Mar 13, 2019

6 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cloverage Your tests passed on CircleCI!
Details
ci/circleci: doo Your tests passed on CircleCI!
Details
ci/circleci: ok Your tests passed on CircleCI!
Details
ci/circleci: war Your tests passed on CircleCI!
Details
ci/circleci: without-db Your tests passed on CircleCI!
Details

@hukka hukka deleted the email-poller-652 branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.