Skip to content

Feature/enable standalone ssl support #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 19, 2019
Merged

Feature/enable standalone ssl support #16

merged 5 commits into from
Aug 19, 2019

Conversation

@sampsapenna
Copy link
Member

@sampsapenna sampsapenna commented Aug 19, 2019

Description

Re-enabled (and made it working as well) TLS as an option on the backend and improved the testing coverage a bit.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Changes made

  • Add back the run_server_secure -function
  • Update the documentation concerning the TLS, to include the possibility to run the server securely when running stand-alone
  • Added some additional tests for server.py module functions
  • Added new environment variables and command line arguments for specifying the SSL/TLS certificate

Testing

  • Unit Tests

@sampsapenna
Re-enable HTTPS as an option.
9a7e00d 
HTTPS was previously disabled in standalone mode (not running with a
TLS termination proxy) due to difficulties in getting it properly
running. Now the problems are fixed and running with HTTPS has been
enabled again.

Also added CLI options for specifying the SSL certificates for HTTPS.
@sampsapenna
Update documentation after introducing SSL.
3434b55
@sampsapenna
Add server run and shutdown function tests.
234c6e6
@sampsapenna sampsapenna requested a review from blankdots August 19, 2019 06:35
@blankdots blankdots merged commit 7436f42 into devel Aug 19, 2019
@blankdots blankdots deleted the feature/enable-standalone-ssl-support branch August 19, 2019 10:42
sampsapenna pushed a commit that referenced this pull request Jul 27, 2021
@blankdots
Merge pull request #16 from CSCfi/feature/fix-js-to-camel
5f792a5 
Chagne js naming convention to camelCase.
sampsapenna pushed a commit that referenced this pull request Jul 27, 2021
@blankdots
Merge pull request #16 from CSCfi/devel
d415cca 
Merge signature enhancements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blankdots blankdots blankdots approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sampsapenna sampsapenna

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sampsapenna @blankdots