Fix incorrect status codes in error middleware. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error middleware was overwriting the status codes set in initialization of the aiohttp.web.FileResponse. Thus, a custom "FileResponse" was made to fix this, while additionally preventing the caching of the error responses with correct headers.
sampsapenna
deleted the
bugfix/listing-fetch-break-after-project-change
branch
sampsapenna
pushed a commit
that referenced
this pull request
Jul 27, 2021
Merge authentication support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error middleware was overwriting the status codes set in
initialization of the aiohttp.web.FileResponse. Thus, a
custom "FileResponse" was made to fix this, while additionally
preventing the caching of the error responses with correct
headers.
Related issues
Fixes #19
Type of change
Changes Made
Testing