fix url rewrite when path is present #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannyle
approved these changes
Feb 17, 2023
Contributor
hannyle
left a comment
hannyle
left a comment
There was a problem hiding this comment.
Looks good to me! It's nice to know about this issue.
Could we have a Changelog update for this ?
hannyle
approved these changes
Feb 17, 2023
sampsapenna
force-pushed
the
feature/download-and-decrypt-files
branch
2 times, most recently
from
62c9107 to
56694af
Compare
Member
|
@blankdots #929 was rebased and had some new changes – meaning this branch needs to be rebased as well. I can do it in case you don't have time for it, but you probably have a better grasp on how to resolve any conflicts in this. |
Contributor
Author
@sampsapenna should have merged this before rebasing, but I can try to see what has happened |
blankdots
force-pushed
the
bugfix/redirect-in-deployment
branch
2 times, most recently
from
b9d1767 to
89fd547
Compare
URL strips path from base url so when deploying we are not getting the correct path
blankdots
force-pushed
the
bugfix/redirect-in-deployment
branch
from
89fd547 to
2571a7b
Compare
sampsapenna
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
URL strips path from base url so when deploying we are not getting the correct path
Related issues
Type of change
Changes Made
Testing
Mentions