Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

feature/json (issue#36) #88

Merged
merged 3 commits into from Nov 8, 2018
Merged

feature/json (issue#36) #88

merged 3 commits into from Nov 8, 2018

Conversation

leezaweb
Copy link
Contributor

@leezaweb leezaweb commented Nov 7, 2018

issue #36

@leezaweb leezaweb added this to In progress in Launch via automation Nov 7, 2018
@leezaweb leezaweb moved this from In progress to Needs review in Launch Nov 7, 2018
Launch automation moved this from Needs review to Reviewer approved Nov 8, 2018
jnschrag
jnschrag approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@jnschrag jnschrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! The only change I made was to update the gulp_watch task so it also watches the JSON files.

@jnschrag jnschrag merged commit 983a269 into master Nov 8, 2018
Launch automation moved this from Reviewer approved to Done Nov 8, 2018
@jnschrag jnschrag deleted the feature/json branch November 8, 2018 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jnschrag jnschrag jnschrag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Launch
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leezaweb @jnschrag