links not working in fade mode #346

Closed
lhwparis opened this Issue May 15, 2012 · 12 comments

Comments

Projects
None yet
3 participants
@lhwparis

links in anything slider content not working correctly in some browsers because you just set opacity:0 and do no reorder slider elements or hide them. please display:none all slider elements NOT visible at the moment (after animation done) to avoid this issue

@Mottie

This comment has been minimized.

Show comment
Hide comment
@Mottie

Mottie May 15, 2012

Member

In the main demo, when I click on the link inside the quote slide, it works properly.

Which browser is having this issue? Could you please share an example of a link not working.

The main reason the slider doesn't apply display none to panels is because of videos. When videos are hidden, they reset and therefore you cannot continue playing a video from its last position when it pauses on panel change.

Member

Mottie commented May 15, 2012

In the main demo, when I click on the link inside the quote slide, it works properly.

Which browser is having this issue? Could you please share an example of a link not working.

The main reason the slider doesn't apply display none to panels is because of videos. When videos are hidden, they reset and therefore you cannot continue playing a video from its last position when it pauses on panel change.

@lhwparis

This comment has been minimized.

Show comment
Hide comment
@lhwparis

lhwparis May 16, 2012

mh the demo works for me too. i have more html in my slides as the demo has. i ll try to find out what causes the problem but it defnitly works when i hide the other slides. i ll post my results

mh the demo works for me too. i have more html in my slides as the demo has. i ll try to find out what causes the problem but it defnitly works when i hide the other slides. i ll post my results

@Mottie

This comment has been minimized.

Show comment
Hide comment
@Mottie

Mottie May 20, 2012

Member

Any word on this? If you could share some of the HTML/CSS for a slide, or better yet a demo I could help find the problem.

Member

Mottie commented May 20, 2012

Any word on this? If you could share some of the HTML/CSS for a slide, or better yet a demo I could help find the problem.

@paliradu

This comment has been minimized.

Show comment
Hide comment
@paliradu

paliradu Jun 1, 2012

I am having a similar issue. The 1st slide doesn't let me click on the link (the Heading at the top left corner of the slide). We've created a CMS to allow oruselves to create new slides easily from the backend as well as reorder them.

I've noticed that it doesnt' matter which is the 1st slide (if it contains a video or not), the link simply doesnt' work.

If I click next then back to the 1st slide, then the link is clickable just fine.

Does anyone have any solutions for this?

paliradu commented Jun 1, 2012

I am having a similar issue. The 1st slide doesn't let me click on the link (the Heading at the top left corner of the slide). We've created a CMS to allow oruselves to create new slides easily from the backend as well as reorder them.

I've noticed that it doesnt' matter which is the 1st slide (if it contains a video or not), the link simply doesnt' work.

If I click next then back to the 1st slide, then the link is clickable just fine.

Does anyone have any solutions for this?

@paliradu

This comment has been minimized.

Show comment
Hide comment
@Mottie

This comment has been minimized.

Show comment
Hide comment
@Mottie

Mottie Jun 1, 2012

Member

Hi paliradu!

I tested that demo in Chrome and all of the links (the last panel doesn't have a link) work for me, at least in Chrome. Is there a particular browser with this issue?

Member

Mottie commented Jun 1, 2012

Hi paliradu!

I tested that demo in Chrome and all of the links (the last panel doesn't have a link) work for me, at least in Chrome. Is there a particular browser with this issue?

@lhwparis

This comment has been minimized.

Show comment
Hide comment
@lhwparis

lhwparis Jun 1, 2012

thats exactly my problem :) thanks for the demo @paliradu.

@Mottie i have the problem in latest firefox version 12.0. the link in the first slide is not clickable after page load. if you slide to slide2 and back to slide1 the link is clickable.

lhwparis commented Jun 1, 2012

thats exactly my problem :) thanks for the demo @paliradu.

@Mottie i have the problem in latest firefox version 12.0. the link in the first slide is not clickable after page load. if you slide to slide2 and back to slide1 the link is clickable.

@paliradu

This comment has been minimized.

Show comment
Hide comment
@paliradu

paliradu Jun 1, 2012

Ok, we've found the bug. Basically the 1st panel should have Class: ActivePage on load.

If you load the page and look at the DOM with Google's Inspector you will see that all the panels have got class="panel" including the very first panel.

As soon as you click on next, the 2nd panel gets class="panel activePage". Then when you click back arrow, the 1st panel gets class="panel activePage" and the link works just fine.

So the solution is to asign activePage class to the first panel on Load.

If anyone could write the code here and let me know in which file this code should be inserted, that would be much appreciated.

Radu

paliradu commented Jun 1, 2012

Ok, we've found the bug. Basically the 1st panel should have Class: ActivePage on load.

If you load the page and look at the DOM with Google's Inspector you will see that all the panels have got class="panel" including the very first panel.

As soon as you click on next, the 2nd panel gets class="panel activePage". Then when you click back arrow, the 1st panel gets class="panel activePage" and the link works just fine.

So the solution is to asign activePage class to the first panel on Load.

If anyone could write the code here and let me know in which file this code should be inserted, that would be much appreciated.

Radu

@Mottie

This comment has been minimized.

Show comment
Hide comment
@Mottie

Mottie Jun 1, 2012

Member

Hi Radu!

Thanks for working out the problem. I'll work on fixing the problem!

Member

Mottie commented Jun 1, 2012

Hi Radu!

Thanks for working out the problem. I'll work on fixing the problem!

@paliradu

This comment has been minimized.

Show comment
Hide comment
@paliradu

paliradu Jun 1, 2012

Great. Thanks for addressing that. Please update here once there is a fix.

paliradu commented Jun 1, 2012

Great. Thanks for addressing that. Please update here once there is a fix.

@Mottie Mottie closed this in 59ff1fb Jun 2, 2012

@Mottie

This comment has been minimized.

Show comment
Hide comment
@Mottie

Mottie Jun 2, 2012

Member

LOL sorry, the commit automatically closed this issue. The problem should be fixed now, but please feel free to reopen it if you continue to have problems.

Thanks @paliradu again for helping to isolate the problem!

Member

Mottie commented Jun 2, 2012

LOL sorry, the commit automatically closed this issue. The problem should be fixed now, but please feel free to reopen it if you continue to have problems.

Thanks @paliradu again for helping to isolate the problem!

@paliradu

This comment has been minimized.

Show comment
Hide comment
@paliradu

paliradu Jun 6, 2012

No worries. Thanks for posting the fix.

Radu

paliradu commented Jun 6, 2012

No worries. Thanks for posting the fix.

Radu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment