Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added borders to fallback-colors rule #307

Merged
merged 3 commits into from Jan 17, 2013

Conversation

Projects
None yet
3 participants
Contributor

fracmak commented Sep 24, 2012

adds all variations of border to the fallback-colors rule.

I also updated the unit test for just a simple border because there were only unit tests for background-color, and color but not for background. If you want me to update the test for the 5 other variations of border as well as background, let me know.

Contributor

nzakas commented Nov 13, 2012

Sorry for missing this, if you can add the tests for the other variations, we can merge it in.

Contributor

fracmak commented Nov 14, 2012

Additional tests added

Contributor

stubbornella commented Jan 1, 2013

Looks like the build failed. @fracmak can you check it out?

Contributor

nzakas commented Jan 1, 2013

That may be due to Rhino's limited stack size. I switched over the Travis
build to use Node instead not too long ago. It might be okay the way it is,
but would be good to verify.

On Mon, Dec 31, 2012 at 5:35 PM, Nicole Sullivan
notifications@github.comwrote:

Looks like the build failed. @fracmak https://github.com/fracmak can
you check it out?


Reply to this email directly or view it on GitHubhttps://github.com/stubbornella/csslint/pull/307#issuecomment-11786654.


Nicholas C. Zakas
@SlickNet

Author, Professional JavaScript for Web Developers
Buy it at Amazon.com:
http://www.amazon.com/Professional-JavaScript-Developers-Nicholas-Zakas/dp/1118026691/ref=sr_1_3

Contributor

fracmak commented Jan 2, 2013

closing and reopening so travis will run again

@fracmak fracmak closed this Jan 2, 2013

@fracmak fracmak reopened this Jan 2, 2013

Contributor

fracmak commented Jan 2, 2013

tests are passing

nzakas added a commit that referenced this pull request Jan 17, 2013

Merge pull request #307 from fracmak/fallback_border_colors
Added borders to fallback-colors rule

@nzakas nzakas merged commit fb58a8e into CSSLint:master Jan 17, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment