Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit call to kill command #202

Conversation

MattyTheHacker
Copy link
Member

No description provided.

@MattyTheHacker
Copy link
Member Author

Do you have a link to the documentation that shows that exiting with exit code 0 will tell docker not to do a restart?

nah - but we're set to "Always" which says that if it's manually shut down it won't attempt to restart. The "on-failure" config option says it considers an error to be a non-zero exit code so assumed 🤷 don't ask me shit like this as if I have any idea what I'm doing lmfao /lh

fwiw: https://docs.docker.com/config/containers/start-containers-automatically/

Matt Norton added 3 commits May 9, 2024 20:21
…igure-kill-command-to-use-the-correct-exit-code-so-that-it-is-not-restarted-by-dockers-restart-policy
Matt Norton added 2 commits May 11, 2024 02:46
…t-exit-code-so-that-it-is-not-restarted-by-dockers-restart-policy
@MattyTheHacker
Copy link
Member Author

image

Appears to be intended functionality - but just as an fyi

@CarrotManMatt CarrotManMatt merged commit b157c41 into main May 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment Changes to the deployment or CI/CD configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants